Possible bug in gstadapter

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible bug in gstadapter

Baby Octopus
Hi,

I'm using rndbuffersize element between mpegtsmux and udpsink in order to split data into chunks. I see a buggy behaviour. Assume that a parent buffer is split into seven chunks of children buffers. Only the first chunk has the valid pts of the parent buffer. Rest 6 buffer have pts of 18446744073709551615.

I digged into gstadapter.c file and found out in the function gst_adapter_take_buffer(), line:767, only first extraction of buffer is giving valid buffer pts. Rest all are initialized to max value of 18446744073709551615

Is this a bug? I'm using 1.0.4 of gstreamer

~BO
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in gstadapter

Tim-Philipp Müller-2
On Mon, 2013-07-22 at 09:02 -0700, Baby Octopus wrote:

Hi,

>
> I'm using rndbuffersize element between mpegtsmux and udpsink in order to
> split data into chunks. I see a buggy behaviour. Assume that a parent buffer
> is split into seven chunks of children buffers. Only the first chunk has the
> valid pts of the parent buffer. Rest 6 buffer have pts of
> 18446744073709551615.
>
> I digged into gstadapter.c file and found out in the function
> gst_adapter_take_buffer(), line:767, only first extraction of buffer is
> giving valid buffer pts. Rest all are initialized to max value of
> 18446744073709551615
>
> Is this a bug? I'm using 1.0.4 of gstreamer

It's expected behaviour.

18446744073709551615 = -1 = no pts set.

Cheers
 -Tim

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in gstadapter

Baby Octopus
But should not all the children buffer have the same tim stamp as that of the parent buffer?

~BO
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in gstadapter

Baby Octopus
Ping :-)

Still not very clear with this. I still feel all the derivative buffers should have the same timestamp as that of the parent buffer. Does such an assumption break any usecase or element behaviour?

~BO
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in gstadapter

Tim-Philipp Müller-2
On Thu, 2013-08-22 at 01:51 -0700, Baby Octopus wrote:
> Ping :-)
>
> Still not very clear with this. I still feel all the derivative buffers
> should have the same timestamp as that of the parent buffer. Does such an
> assumption break any usecase or element behaviour?

You don't know anything about the data in the adapter. If the child
buffer starts at offset 0 of the parent buffer, it would probably be ok
to return the same timestamp, but it's less clear for other use cases. I
don't think you can make general assumptions here. There's API to
retrieve the last pts/dts and the distance.

Cheers
 -Tim

_______________________________________________
gstreamer-devel mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in gstadapter

Baby Octopus
True. Agreed!

~BO