Quantcast

[PATCH] basetransform: typo fix: remove unbalanced closing parenthesis in debug log

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] basetransform: typo fix: remove unbalanced closing parenthesis in debug log

Yasushi SHOJI
This unbalanced closing parenthesis is leftover from the commit
8b739d91e7.  It used to wrap the caps but we don't seem to do that in
the current code.

So, just remove it.  No functionality has been changed.
---

Hi all,

I just noticed a typo while reading the base transform code.  It
doesn't no bug.  Just a debug log.


 libs/gst/base/gstbasetransform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c
index e10a32845..3157fb725 100644
--- a/libs/gst/base/gstbasetransform.c
+++ b/libs/gst/base/gstbasetransform.c
@@ -1797,7 +1797,7 @@ gst_base_transform_get_unit_size (GstBaseTransform * trans, GstCaps * caps,
   bclass = GST_BASE_TRANSFORM_GET_CLASS (trans);
   res = bclass->get_unit_size (trans, caps, size);
   GST_DEBUG_OBJECT (trans,
-      "caps %" GST_PTR_FORMAT ") has unit size %" G_GSIZE_FORMAT ", res %s",
+      "caps %" GST_PTR_FORMAT " has unit size %" G_GSIZE_FORMAT ", res %s",
       caps, *size, res ? "TRUE" : "FALSE");
 
   if (res) {
--
2.11.0

_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] basetransform: typo fix: remove unbalanced closing parenthesis in debug log

Nicolas Dufresne-5
Le mercredi 29 mars 2017 à 19:26 +0900, Yasushi SHOJI a écrit :

> This unbalanced closing parenthesis is leftover from the commit
> 8b739d91e7.  It used to wrap the caps but we don't seem to do that in
> the current code.
>
> So, just remove it.  No functionality has been changed.
> ---
>
> Hi all,
>
> I just noticed a typo while reading the base transform code.  It
> doesn't no bug.  Just a debug log.
Thanks, note that we don't take any email patch submission in the
GStreamer project. Patches are submitted through bugs.gnome.org on
product GStreamer (this case is component GStreamer (core))). You file
a bug, and attach 1 or more patches. There exist git-bz if you need to
use this very often.

regards,
Nicolas

>
>
>  libs/gst/base/gstbasetransform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libs/gst/base/gstbasetransform.c
> b/libs/gst/base/gstbasetransform.c
> index e10a32845..3157fb725 100644
> --- a/libs/gst/base/gstbasetransform.c
> +++ b/libs/gst/base/gstbasetransform.c
> @@ -1797,7 +1797,7 @@ gst_base_transform_get_unit_size
> (GstBaseTransform * trans, GstCaps * caps,
>    bclass = GST_BASE_TRANSFORM_GET_CLASS (trans);
>    res = bclass->get_unit_size (trans, caps, size);
>    GST_DEBUG_OBJECT (trans,
> -      "caps %" GST_PTR_FORMAT ") has unit size %" G_GSIZE_FORMAT ",
> res %s",
> +      "caps %" GST_PTR_FORMAT " has unit size %" G_GSIZE_FORMAT ",
> res %s",
>        caps, *size, res ? "TRUE" : "FALSE");
>  
>    if (res) {
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] basetransform: typo fix: remove unbalanced closing parenthesis in debug log

Yasushi SHOJI
Hi Nicolas,

On Wed, Mar 29, 2017 at 11:30 PM, Nicolas Dufresne <[hidden email]> wrote:
> Thanks, note that we don't take any email patch submission in the
> GStreamer project. Patches are submitted through bugs.gnome.org on
> product GStreamer (this case is component GStreamer (core))). You file
> a bug, and attach 1 or more patches. There exist git-bz if you need to
> use this very often.

Sorry for a late reply.  I just did that with git-bz.
https://bugzilla.gnome.org/show_bug.cgi?id=781484

Hope I didn't messed up anything.

regards,
--
             yashi
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Loading...