Quantcast

API/ABI changes review for ORC

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

API/ABI changes review for ORC

Andrey Ponomarenko
The review of API/ABI changes for ORC library since 0.4.0 version: https://abi-laboratory.pro/tracker/timeline/orc/

Created with the help of open-source abi-tracker tool: https://github.com/lvc/abi-tracker. Hope it will be helpful for users and maintainers of the library.

## Environment
* Linux x86_64
* GCC 4.9
* ORC 0.4.0 and higher
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[FALSE POSITIVE] Re: API/ABI changes review for ORC

Nicolas Dufresne-5
Le mercredi 26 avril 2017 à 09:02 +0300, Andrey Ponomarenko a écrit :
> The review of API/ABI changes for ORC library since 0.4.0 version:
> https://abi-laboratory.pro/tracker/timeline/orc/

Everything in OrcProgram structure is private (see /*<private>*/
notation) and OrcProgram should never be stored in your application.
Hence, this is yet another false positive from this tool (just like all
the wrong report about API/ABI break in dev branches.

Now, arguably, the way this header leak the internal details of the
OrcProgram is not elegant. We should make the declaration go away in my
 opinion.

regards,
Nicolas
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [FALSE POSITIVE] Re: API/ABI changes review for ORC

Nicolas Dufresne-5
Thanks for the notification by the way. Would it be possible to allow
marking online the false positive when they are found ? Otherwise it
makes projects looks bad in my opinion.

cheers,
Nicolas

Le mercredi 26 avril 2017 à 09:26 -0400, Nicolas Dufresne a écrit :

> Le mercredi 26 avril 2017 à 09:02 +0300, Andrey Ponomarenko a écrit :
> > The review of API/ABI changes for ORC library since 0.4.0 version:
> > https://abi-laboratory.pro/tracker/timeline/orc/
>
> Everything in OrcProgram structure is private (see /*<private>*/
> notation) and OrcProgram should never be stored in your application.
> Hence, this is yet another false positive from this tool (just like
> all
> the wrong report about API/ABI break in dev branches.
>
> Now, arguably, the way this header leak the internal details of the
> OrcProgram is not elegant. We should make the declaration go away in
> my
>  opinion.
>
> regards,
> Nicolas
_______________________________________________
gstreamer-devel mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel

signature.asc (188 bytes) Download Attachment
Loading...